Enhance omis oep table metadata tests #110
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After omi was reworked, the testing system now attempts to validate data from table/metadata that is already on the OEP. The table that was used so far does not exist anymore, the test is failing.
This PR attempts fix this issue by using the sandbox schema for testing. Additionally, the table could be recreated if it does not exist anymore, as the sandbox schema is also cleaned up from time to time.
During implementation i noticed that the OEP breaks schema validity of metadata that is uploaded as the OEP will fill all missing fields with "null" values. The json schema validation breaks after this change, as some fields are not expected to be None/null.
What is new
New table for testing:
sandox.omi_test_table_meta_v16you can find the metadata that is available here:https://openenergyplatform.org/api/v0/schema/sandbox/tables/omi_test_table_meta_v16/meta/
Table for oem v20 will follow